----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26622/ -----------------------------------------------------------
(Updated Oct. 17, 2014, 11:40 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy Chen. Changes ------- Updated the title to more accurately reflect the severity of the bug. It would be awesome to get this little 3-line changeset merged for the next point-release to fix a feature that has never worked. Summary (updated) ----------------- Command Executor is broken when used with shell=false Bugs: MESOS-1873 https://issues.apache.org/jira/browse/MESOS-1873 Repository: mesos-git Description (updated) ------- Basically if you use "shell=false" with a non-empty argument list and the Command Executor it is completely broken. When we clone the env vars to fork "mesos-executor" all of the original cmd args are cloned as well (unintentionally) due to some protocol-buffer merge shenanigans. Don't pass task-related arguments to mesos-executor. The description on the linked jira ticket goes into more detail. Diffs ----- src/slave/slave.cpp 0e342ed src/tests/slave_tests.cpp f585bdd Diff: https://reviews.apache.org/r/26622/diff/ Testing ------- make check added new test "SlaveTest.GetExecutorInfo" verifying the explicit desired behavior. Thanks, R.B. Boyer