----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26702/#review57295 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/26702/#comment97911> Hm.. since we don't look at this state on the slave side, maybe a comment? For now there is no difference. src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/26702/#comment97912> Could you restructure this really long sentence? - Ben Mahler On Oct. 17, 2014, 12:31 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26702/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 12:31 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1799 and MESOS-1817 > https://issues.apache.org/jira/browse/MESOS-1799 > https://issues.apache.org/jira/browse/MESOS-1817 > > > Repository: mesos-git > > > Description > ------- > > Master responds to reconciliation requests with unacknowledged state of task > instead of latest state. > > > Diffs > ----- > > src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4 > src/tests/reconciliation_tests.cpp 400c5c035a2cadd408636021aafb3888546f0081 > > Diff: https://reviews.apache.org/r/26702/diff/ > > > Testing > ------- > > make check > > Ran new test 1000 times. > > > Thanks, > > Vinod Kone > >
