----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review57308 -----------------------------------------------------------
src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/26862/#comment97984> Feel free to just have 'create' return an Owned<Docker> too. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/26862/#comment97985> Feel free to just have 'create' return an Owned<Docker> too. I know that is not consistent throughout the codebase but it would be great to move in that direction. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/26862/#comment97987> Can we put this back in the review for scheduling the container removal? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/26862/#comment97988> But it's not really owned! src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/26862/#comment97989> Why are we removing the Docker container? Isn't this test making sure that it gets removed without us doing this already!? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/26862/#comment97990> I think we should be checking whether or not the container is actually running here. That's a fundamental part of these tests IIUC! src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/26862/#comment97991> Let's do this right and set up EXPECT_CALLs like we do with other mocks. :-) - Benjamin Hindman On Oct. 17, 2014, 7:33 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26862/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 7:33 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Docker tests are flaky, mostly around getting expected output from the docker > container forwarded to stdout/stderr. > > This is due to Docker not always have the stdout/stderr output available for > docker logs if kill/rm is called. > > > Diffs > ----- > > src/docker/docker.hpp 9656f15 > src/docker/docker.cpp e09b51c > src/slave/containerizer/docker.hpp fbbd45d > src/slave/containerizer/docker.cpp 9a29489 > src/tests/docker_containerizer_tests.cpp 67d60a8 > src/tests/docker_tests.cpp 04139af > src/tests/environment.cpp 4dd78e7 > > Diff: https://reviews.apache.org/r/26862/diff/ > > > Testing > ------- > > make with gtest_repeat=-1 gtest_shuffle=1 > > > Thanks, > > Timothy Chen > >
