----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review57365 -----------------------------------------------------------
Ship it! src/slave/containerizer/isolators/filesystem/shared.cpp <https://reviews.apache.org/r/25549/#comment98018> Please make sure to wrap the comments in 70 char width. Here and everywhere else. If you are using vim, set tw=70 :) src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25549/#comment98024> I still don't get it. Is this absolute necessary? Why volumes need to be mounted first? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25549/#comment98016> Why removing this check? - Jie Yu On Oct. 15, 2014, 7:25 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25549/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 7:25 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1586 > https://issues.apache.org/jira/browse/MESOS-1586 > > > Repository: mesos-git > > > Description > ------- > > Does not report usage or enforce quota but can create 'private' directories > for each container which mask parts of the shared host filesystem. > > This review replaces https://reviews.apache.org/r/24178/ because of some file > renaming. I addressed all comments from earlier reviews. > > > Diffs > ----- > > include/mesos/mesos.proto 6b93e9000761857c4f335f2a8c8088e155078f54 > src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 > src/common/parse.hpp c9ca30fde5580d8e388f3c616e78df2b032ac0ad > src/common/type_utils.hpp f10b2d31f2781bd056898f93eb8e8b6d9809e80b > src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp > f7bc894830a7ca3f55465dacc7b653cdc2d7758b > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > src/slave/slave.cpp 0e342ed35e3db3b68f9f32b6cf4ace23e4a4db38 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 > > Diff: https://reviews.apache.org/r/25549/diff/ > > > Testing > ------- > > make check # added a test > > > Thanks, > > Ian Downes > >
