----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26846/#review57610 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/26846/#comment98402> Is it worth saying that it's because we made the change in 0.21.0, to be explicit about the phased aspect of this TODO? Hm.. I guess we actually use 'pid' to know when an ack is needed. src/slave/slave.cpp <https://reviews.apache.org/r/26846/#comment98404> Wonder if we could log this a little more succinctly: ``` "because the slave is TERMINATING" // vs. "because the slave is in TERMINATING state" ``` src/slave/slave.cpp <https://reviews.apache.org/r/26846/#comment98411> Hm... not sure what you mean here by (because no acknowledgements might be received), is this saying that if we are removing an executor, we either want there to be (1) no pending updates needed, or (2) the slave/framework are terminating, at which point we can't receive acks? - Ben Mahler On Oct. 20, 2014, 11:48 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26846/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 11:48 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > All the updates from the status update manager are funnelled via the slave. > No more sending updates in the middle of recovery or disconnection. Yay. > > Had to cleanup flags.recover = "cleanup" semantics because the updates are no > longer sent when the slave is disconnected. > > > Diffs > ----- > > src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4 > src/slave/slave.hpp ccc0e03edbd41d9ce3bb0f6b0447bf4240648986 > src/slave/slave.cpp 7b5474ae898f369fc55670cf1dbbee684bc0ae4b > src/slave/status_update_manager.hpp > c371e5542e12cd6bb9401591cd691d99bc0fa8fd > src/slave/status_update_manager.cpp > 5d5cf234ef2dd47fa4b1f67be761dbca31659451 > src/tests/slave_recovery_tests.cpp 4fb357bd55f69f71193e92fd03765b808f932d33 > > Diff: https://reviews.apache.org/r/26846/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
