> On Oct. 20, 2014, 4:14 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/docker.hpp, line 36 > > <https://reviews.apache.org/r/26517/diff/3/?file=724991#file724991line36> > > > > Are all directories symlinked?
Only the ones that has colon in the path. > On Oct. 20, 2014, 4:14 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/docker.cpp, line 547 > > <https://reviews.apache.org/r/26517/diff/3/?file=724992#file724992line547> > > > > Is this container always present? If so, we should be adding a CHECK* > > and a comment as to why this is a valid function precondition. Also, if > > we're looking up 'directory' why not look up the CommandInfo too? Seems > > weird to look one up but not the other. Alternatively you could have looked > > up 'directory' at the call sites to 'fetch'. To be clear, I don't mind > > looking up the container, but we might as well look up everything from it > > then to keep people from guessing why we didn't! Sure, although it's never used anywhere else than fetch. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review57307 ----------------------------------------------------------- On Oct. 17, 2014, 10:57 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26517/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 10:57 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1833 > https://issues.apache.org/jira/browse/MESOS-1833 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/26517 > > > Diffs > ----- > > src/slave/containerizer/docker.hpp fbbd45d > src/slave/containerizer/docker.cpp 9a29489 > src/tests/docker_containerizer_tests.cpp 67d60a8 > > Diff: https://reviews.apache.org/r/26517/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
