----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26459/#review57892 -----------------------------------------------------------
Why stick the S and O in the middle of the ID, why not as a prefix? - Ben Mahler On Oct. 22, 2014, 8:30 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26459/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 8:30 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1970 > https://issues.apache.org/jira/browse/MESOS-1970 > > > Repository: mesos-git > > > Description > ------- > > slave and offer ids can be identical which is confusing in logs > > > Diffs > ----- > > src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f > > Diff: https://reviews.apache.org/r/26459/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
