----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27094/#review58078 -----------------------------------------------------------
Bad patch! Reviews applied: [27094] Failed command: ./support/apply-review.sh -n -r 27094 Error: --2014-10-23 20:00:37-- https://reviews.apache.org/r/27094/diff/raw/ Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74 Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 658 [text/x-patch] Saving to: '27094.patch' 0K 100% 40.4M=0s 2014-10-23 20:00:37 (40.4 MB/s) - '27094.patch' saved [658/658] Traceback (most recent call last): File "./support/jsonurl.py", line 25, in <module> print data UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in position 13: ordinal not in range(128) Successfully applied: set cgroups_limit_swap default as true This sets cgroups\_limit\_swap default as true, the details of the flag is discussed in MESOS-1662. Thanks! Review: https://reviews.apache.org/r/27094 fatal: empty ident name (for <anton+me...@alley.se>) not allowed Failed to commit patch - Mesos ReviewBot On Oct. 23, 2014, 6:59 p.m., Anton Lindström wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27094/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 6:59 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1971 > https://issues.apache.org/jira/browse/MESOS-1971 > > > Repository: mesos-git > > > Description > ------- > > This sets cgroups_limit_swap default as true, the details of the flag is > discussed in MESOS-1662. > > Thanks! > > > Diffs > ----- > > src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1 > > Diff: https://reviews.apache.org/r/27094/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anton Lindström > >
