----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27051/ -----------------------------------------------------------
(Updated Oct. 23, 2014, 5:55 p.m.) Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Till Toenshoff. Changes ------- Update help message for --modules. Bugs: MESOS-1896 https://issues.apache.org/jira/browse/MESOS-1896 Repository: mesos-git Description ------- The Modules protobuf is enhance to support key-value parameters based on mesos::Parameter and mesos::Parameters. Bumped Module API version since we modified the signature of create() method. Diffs (updated) ----- include/mesos/module.hpp 5bafb402162d0f2c86b8802937b96ba518cea226 src/examples/example_module_impl.cpp 6a48d670d8df15b6da3e7e5d91be5cc2973bd0ee src/examples/test_isolator_module.cpp 2d6b427e1adba8df958c35e7468ef74446b3ea07 src/examples/test_module.hpp 820df234ee4471eb354a3985dba2f31514744690 src/master/flags.hpp 9d068564e52dbd2c98a3689c204e56e097ed0e6f src/messages/messages.proto 6e49fe7c91a1e171a45764fe0432c20f5f14d133 src/module/isolator.hpp fc78b072e0ce2c54e350bebd0419e9af5ae0e57e src/module/manager.hpp dc789218db05b29ff93db5284797f1daf0028e90 src/module/manager.cpp 63056a4813d74d8a2bdb0233e477842e627d940f src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1 src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337 src/tests/module.cpp 45becade73c79b15e737e325f73185715a01eeca src/tests/module_tests.cpp 45125d86bbc76b7ed2b2f630fff878a0d548a0e7 Diff: https://reviews.apache.org/r/27051/diff/ Testing ------- Added new tests and ran make check. Thanks, Kapil Arya