----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27120/#review58181 -----------------------------------------------------------
Ship it! I'll commit this once you address the comments. src/slave/slave.cpp <https://reviews.apache.org/r/27120/#comment99114> s/and will/and the '--checkpoint' flag will/ s/Migrate to enabling checkpointing/Please avoid using this flag/ src/slave/slave.cpp <https://reviews.apache.org/r/27120/#comment99115> Can you also add a blurb in the CHANGELOG for 0.21.0 (under deprecations) that this will be deprecated? - Vinod Kone On Oct. 24, 2014, 12:04 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27120/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 12:04 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-1986 and mesos-444 > https://issues.apache.org/jira/browse/mesos-1986 > https://issues.apache.org/jira/browse/mesos-444 > > > Repository: mesos-git > > > Description > ------- > > Formally deprecate disabling checkpointing (--checkpoint=false). Adds a > message to --help, as well as a warning in a log that --checkpoint=false will > be removed in a future release. > > > Diffs > ----- > > src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1 > src/slave/slave.cpp 55e5264a61ce43970e177cf0eb27dc8a2657e261 > > Diff: https://reviews.apache.org/r/27120/diff/ > > > Testing > ------- > > make distcheck > > Ran mesos-slave, verified the log message printed and > > > Thanks, > > Cody Maloney > >
