----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26426/#review58330 -----------------------------------------------------------
Ship it! Thanks Cody! Just some trivial comments below and we can get this committed! configure.ac <https://reviews.apache.org/r/26426/#comment99282> Can you wrap after the comma to be consistent with the other AC_ARG_ENABLE blocks? Any reason to do it differently here? configure.ac <https://reviews.apache.org/r/26426/#comment99283> How about s/$debug/$debug_flags/ and s/$optimize/$optimize_flags/ ? - Ben Mahler On Oct. 23, 2014, 9:20 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26426/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 9:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy St. Clair. > > > Repository: mesos-git > > > Description > ------- > > Reworks buiding mesos in a "debug" vs. a "release" configuration. By default, > mesos is built in a developer-centric setup (No optimizations, minimal debug > info), in order to maximize developer productivity > > None: '-O0 -g1' > --enable-optimize == '-O2' > --enable-debug == '-g' > --enable-optimize --enable-debug == '-O2 -g' > > If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not > changed / touched at all. This is important so that Mesos is a good citizen > when being built for various distributions (As well as making it so > specialized one-off groupings of flags are feasible to use). > > Adds two defines for accessing what mode things are being built in: 'DEBUG' > and 'OPTIMIZE' which can be hooked into later to enable extra logging and the > like. For release builds we may want to set 'NDEBUG' which removes > assert()'s, but that is a seperate discussion. > > > Diffs > ----- > > configure.ac 2b372e06006250b5230956ef096473e98f3fa590 > > Diff: https://reviews.apache.org/r/26426/diff/ > > > Testing > ------- > > Tested all four combinations of flags, making sure they set the right > CXXFLAGS. Also specified > > > Thanks, > > Cody Maloney > >
