----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27127/#review58428 -----------------------------------------------------------
Ship it! src/linux/ns.hpp <https://reviews.apache.org/r/27127/#comment99424> To avoid the race where the process exits right before this, can you check for support based on init or self? src/linux/ns.hpp <https://reviews.apache.org/r/27127/#comment99426> s/buf/s/ src/tests/ns_tests.cpp <https://reviews.apache.org/r/27127/#comment99432> We can use the ROOT_ filter for this and the other tests. src/tests/ns_tests.cpp <https://reviews.apache.org/r/27127/#comment99441> Ditto on !empty - Ben Mahler On Oct. 24, 2014, 9:54 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27127/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 9:54 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > getns() to get the namespace inode. > > > Diffs > ----- > > src/linux/ns.hpp PRE-CREATION > src/tests/ns_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/27127/diff/ > > > Testing > ------- > > make check # new test added > > > Thanks, > > Ian Downes > >
