----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27243/#review58715 -----------------------------------------------------------
Thanks Tim! 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp <https://reviews.apache.org/r/27243/#comment99840> I'd suggest just splitting out the whole call to txdelta within each #ifdef block, might make this a little more clear. Especially since below we have to check for 2 versions. 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp <https://reviews.apache.org/r/27243/#comment99839> svn_txdelta_to_svndiff3 was introduced in 1.7 svn_txdelta_to_svndiff2 was introduced in 1.4 - Ben Mahler On Oct. 27, 2014, 10:21 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27243/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 10:21 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/27243 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp > 117ab0a662bfe2d2b1ec8fa64c6d57bdf1b0004a > > Diff: https://reviews.apache.org/r/27243/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
