----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review58915 -----------------------------------------------------------
The GarbageCollector is one of the earliest libprocess processes that was added. It doesn't follow the preferred 'pimpl' style where we should have both a GarbageCollectorProcess wrapped (via an Owned) in a GarbageCollector, which controls the lifetime via spawn, terminate, and wait. I'd prefer to see us fix this and then simply allocate and free an instance of GarbageCollector. Make sense? - Benjamin Hindman On Oct. 22, 2014, 6:28 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26583/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 6:28 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Wrap the libprocess garbage collector process with a unique ptr. Reset the > ptr during finalization. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 85fb995 > > Diff: https://reviews.apache.org/r/26583/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
