----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/#review59017 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Oct. 29, 2014, 5:26 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27295/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 5:26 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1875 > https://issues.apache.org/jira/browse/MESOS-1875 > > > Repository: mesos-git > > > Description > ------- > > Improve os::killtree() for the case when the root pid has exited and > it has been instructed to either follow process groups or sessions. It > will now kill all processes (and their trees) with pgid or session > matching the root pid. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp > fa1950cc8849fcd81d425c651848e05661111078 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > e9f37dfd3cf54c3ca85d74716b3ee4262b065fad > > Diff: https://reviews.apache.org/r/27295/diff/ > > > Testing > ------- > > Added a test where the root pid exits (and is reaped), leaving behind a > reparented subtree. This test initially fails. > > + // -+- child exit 0 [new session and process group leader] > + // -+- grandchild sleep 100 > + // -+- great grandchild sleep 100 > > > Thanks, > > Ian Downes > >
