----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review58907 -----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/27054/#comment100075> We name our enumerations like constants, and we name our constants in capital letters, like macros. See: http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Enumerator_Names (but note that we don't use the 'k' prefix style for naming, which was only recently "accepted" for enumerations in the Google Style Guide). Check out other examples in the code base too. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/27054/#comment100076> { on newline please. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/27054/#comment100078> This should be virtual, no? 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/27054/#comment100147> We've put friend declarations at the top of the private section because, if you're not a friend, you have no reason to read below that line! ;-) In all seriousness, the rationale here is exactly the same reasoning for why we order public, protected, then private: the class declaration acts as documentation, and most people care about the public members of the class first. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27054/#comment100150> I'd like us to call this struct Connect instead of AsyncConnect since this will not be the first time that we have to create a struct for holding data across continuations and it would be great to set a precedent for naming continuation data. That is, this is a fundamental pattern that we'll replicate. So in the future, we can have an internal::Write which we know maps to a 'write' continuation, etc. Sound good? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27054/#comment100151> Let's stay consistent with how we label our continuations: s/async_receiving_connect/_connect/. - Benjamin Hindman On Oct. 29, 2014, 5:18 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27054/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 5:18 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1330 > https://issues.apache.org/jira/browse/MESOS-1330 > > > Repository: mesos-git > > > Description > ------- > > Introduce the connect(const Node& node) call to Socket. Use it in link() and > send(). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp 6683881 > 3rdparty/libprocess/src/process.cpp 85fb995 > > Diff: https://reviews.apache.org/r/27054/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
