> On Oct. 30, 2014, 12:15 a.m., Adam B wrote: > > src/examples/test_authenticator_module.cpp, line 44 > > <https://reviews.apache.org/r/26857/diff/7/?file=740322#file740322line44> > > > > org_apache_mesos_TestCRAMMD5Authenticator? Then when we add the real > > module, they won't conflict? > > Till Toenshoff wrote: > This already implements a fully functional authenticator. We could > replace the built-in mechanics with this module already without any > drawbacks. Building another CRAM-MD5 SASL authenticator module would not make > any sense. Is that convincing?
Actually, now that I renamed the library, I will also rename the module according to your suggestion. That way we can keep this as an example even if we added another identical variant as a "real" authenticator. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59073 ----------------------------------------------------------- On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26857/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 6:51 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > Introducing the CRAM-MD5 SASL authenticator module based on the former > sasl/authenticator. > > The former sasl/authenticator.hpp still remains as part of libmesos but now > is located at authentication/cram_md5. > > > Diffs > ----- > > src/Makefile.am f177d87 > src/authentication/authenticator.hpp PRE-CREATION > src/authentication/cram_md5/authenticator.hpp PRE-CREATION > src/examples/test_authenticator_module.cpp PRE-CREATION > src/module/authenticator.hpp PRE-CREATION > src/module/manager.cpp 7a6c884 > > Diff: https://reviews.apache.org/r/26857/diff/ > > > Testing > ------- > > make check > > NOTE all four CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
