----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27481/#review59510 -----------------------------------------------------------
Ship it! Great work Kapil. Makes much more sense now. src/tests/module_tests.cpp <https://reviews.apache.org/r/27481/#comment100781> Given that people like me seek the ultimate truth in the tests, I think this one is particularly helpful even though it is arguable on why you basically test JSON to protobuf here. Also this test would have allowed us to spot issues we saw with the earlier version of the libraries protobuf much quicker (documentation was not in sync with json-format). - Till Toenshoff On Nov. 2, 2014, 1:02 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27481/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2014, 1:02 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > Updated the --modules help messages accordingly. > > > Diffs > ----- > > src/master/flags.hpp c931fd99e847477d773c05524f4dee90b8c168cb > src/messages/messages.proto 76e39808457816d67f58f08f4349cc700fd396ee > src/module/manager.cpp 7a6c88444c136dc56898bc5e81fda2c2662e6e68 > src/slave/flags.hpp f7a8cde5826556a477ad22a84b9f50f0d1c8103f > src/tests/flags.hpp 2886e89cd5e2e45983190493cd2a0a20ab96aa6e > src/tests/module_tests.cpp e079dbe58f000d80d111ff87945d37edab0db9b4 > > Diff: https://reviews.apache.org/r/27481/diff/ > > > Testing > ------- > > Updated test suite, added a new test that generates the Modules protobuf by > parsing a Json string and ran make check. > > > Thanks, > > Kapil Arya > >
