----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27622/#review60110 -----------------------------------------------------------
There are still fetcherEnvironment remnants here, but I didn't comment on them here since the dependent review should clean them up. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27622/#comment101449> Let's put newlines in between each of these stanzas so it's easier to read. The code starts to get pretty dense without the newlines: Try<JSON::Object> parse = JSON::parse<JSON::Object>(os::getenv("MESOS_COMMAND_INFO")); if (parse.isError()) { EXIT(1) << "Failed to parse MESOS_COMMAND_INFO: " << parse.error(); } Try<CommandInfo> commandInfo = protobuf::parse<CommandInfo>(parse.get()); if (commandInfo.isError()) { EXIT(1) << "Failed to parse CommandInfo: " << commandInfo.error(); } src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/27622/#comment101451> I don't remember why this got added, but I don't think it's necessary, and the fact that it's in the test is misleading because it makes it look like something needed to get done in order for the test to pass. If it's not necessary can we actually kill this in each test please? Thank you! My bad! src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/27622/#comment101450> Unnecessary newlines? - Benjamin Hindman On Nov. 5, 2014, 6:30 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27622/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 6:30 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1248 > https://issues.apache.org/jira/browse/MESOS-1248 > > > Repository: mesos-git > > > Description > ------- > > Rebasing and replacing https://reviews.apache.org/r/21277/. Now dependent on > https://reviews.apache.org/r/27516/ which implements MESOS-1316. > > Replaces the ad-hoc format for env var values that act as fetcher program > comd line args with a JSON format that is gained by translation from protobuf > parsing to a JSON object. > > > Diffs > ----- > > src/launcher/fetcher.cpp 9323c28237010fa065ef34d74435c151ded530a8 > src/slave/containerizer/containerizer.cpp > 0254679508167a390fd6fed855f19794354ac081 > src/slave/containerizer/fetcher.cpp PRE-CREATION > src/tests/fetcher_tests.cpp d7754009a59fedb43e3422c56b3a786ce80164aa > > Diff: https://reviews.apache.org/r/27622/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Bernd Mathiske > >
