----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27670/#review60295 -----------------------------------------------------------
Ship it! Looks good. src/launcher/fetcher.cpp <https://reviews.apache.org/r/27670/#comment101662> Since Try is either Error or Some, you could just write: if (available.isError() || !available.get()) { - Adam B On Nov. 6, 2014, 11:03 a.m., Ankur Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27670/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 11:03 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1711 > https://issues.apache.org/jira/browse/MESOS-1711 > > > Repository: mesos-git > > > Description > ------- > > @benh noticed that the fetcher would detect the condition where hadoop > returns a success in case of a success non zero value > > > Diffs > ----- > > src/launcher/fetcher.cpp bd95928bc3191970330e839bcf41e343d5142c54 > > Diff: https://reviews.apache.org/r/27670/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --verbose > support/mesos-style.py > > > Thanks, > > Ankur Chauhan > >
