----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27447/#review60301 -----------------------------------------------------------
Patch looks great! Reviews applied: [27446, 27447] All tests passed. - Mesos ReviewBot On Nov. 7, 2014, 3:23 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27447/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 3:23 a.m.) > > > Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched > to 'mcypark'. > > > Bugs: MESOS-2019 > https://issues.apache.org/jira/browse/MESOS-2019 > > > Repository: mesos-git > > > Description > ------- > > At the moment, the Node class is used to keep a mapping from a socket to the > ip & port pair in the process namespace. > I want to propose to extend its use by replacing the ip & port fields from > the UPID class and process namespace with this type. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7 > src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 > src/sched/sched.cpp 8ca052635bf8772a6fa95972931b6254c6e452ef > src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb > src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d > src/slave/slave.cpp 81e0c4ba702d492976f9c771b8d779853c423187 > src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671 > src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451 > src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346 > src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5 > src/tests/master_contender_detector_tests.cpp > 8f7fb18f0ca985364565fc4cd50f113b1461fbe7 > src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf > src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d > > Diff: https://reviews.apache.org/r/27447/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
