> On Nov. 10, 2014, 8:52 p.m., Vinod Kone wrote:
> > src/master/master.cpp, lines 2587-2589
> > <https://reviews.apache.org/r/27769/diff/1/?file=755256#file755256line2587>
> >
> >     Hmm. The task will also not be in 'pendingTasks' if it's a duplicate 
> > taskid right? We need to send a TASK_LOST the duplicates instead of 
> > silently ignoring them!

This issue exists in the current code. I'll follow up with a patch to fix this.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27769/#review60668
-----------------------------------------------------------


On Nov. 8, 2014, 2:13 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27769/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2014, 2:13 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Perform validation while launching each task. In that way, we can simplify a 
> few Task validators. Also, it will simply the validator for persistent disk 
> resources.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7 
>   src/master/master.cpp 0e182a6328e089bcc7e9b173e267f6d5ca357890 
> 
> Diff: https://reviews.apache.org/r/27769/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to