> On Oct. 18, 2014, 2:50 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 528 > > <https://reviews.apache.org/r/26894/diff/1/?file=724949#file724949line528> > > > > Hm.. this doesn't look like the right usage of shell=false (which > > should use the `arguments` field): > > > > > > https://github.com/apache/mesos/blob/0.20.1/include/mesos/mesos.proto#L238 > > R.B. Boyer wrote: > FYI "shell=false" with arguments is broken until this is merged: > https://reviews.apache.org/r/26622/
You are right - we need to introduce a helper program then (I can't think of a way to run the `test` program and whoami at the same time without a shell). So in short, it would be a helper program that does getuid and compares it with the user entry from the argument given: './test-running-user nobody' Ben, how does that sound? - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/#review57283 ----------------------------------------------------------- On Oct. 17, 2014, 3:49 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26894/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 3:49 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1359 > https://issues.apache.org/jira/browse/MESOS-1359 > > > Repository: mesos-git > > > Description > ------- > > The 'nobody' user is restricted on some systems from shell access and broke > the task.user tests (which have been disabled since then). > With the command.shell field, the test can run the command directly. > > > Diffs > ----- > > src/tests/slave_tests.cpp a1bd1d4 > > Diff: https://reviews.apache.org/r/26894/diff/ > > > Testing > ------- > > make check on linux as root > > > Thanks, > > Niklas Nielsen > >
