> On Nov. 11, 2014, 7:28 p.m., Niklas Nielsen wrote: > > Thomas, can you expand a bit on what is going on? It looks like you are > > doing more than just enabling the configuration of the master endpoint?
That's really it. To allow configuration of the master endpoint, a config dialog and directive was introduced. To make sure all configuration is part of that, the existing longDate toggle was moved into that namespace. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review60826 ----------------------------------------------------------- On Oct. 16, 2014, 6:41 p.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17431/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 6:41 p.m.) > > > Review request for mesos, Michael Lunøe and Niklas Nielsen. > > > Bugs: mesos-885 > https://issues.apache.org/jira/browse/mesos-885 > > > Repository: mesos-git > > > Description > ------- > > Enabled configuration of the mesos master from the UI. > > Review: http://reviews.apache.org/r/17431 > > > Diffs > ----- > > src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 > src/webui/master/static/config.html PRE-CREATION > src/webui/master/static/css/mesos.css > 5b1227e9d64757f9fc106e497f7fa3ed72112c10 > src/webui/master/static/directives/timestamp.html > 5e422b9f22f8ddaf987feec3e02a849f21e5e22c > src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 > src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 > src/webui/master/static/js/controllers.js > 41a70a80442501a2bf7b217939dbe504662941d2 > > Diff: https://reviews.apache.org/r/17431/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Config Dialog > > https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png > Connection Issue Alert > > https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png > > > Thanks, > > Thomas Rampelberg > >
