----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27499/#review60887 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27499/#comment102295> How about generalizing as callbacks (a list of callbacks, listeners, observers)? Not religious about it, but would nice to follow the design pattern we are kind of moving towards http://en.wikipedia.org/wiki/Observer_pattern 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27499/#comment102296> If all it does is to add or set the callback, 'initialize' is a bit misleading 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27499/#comment102293> It took me a while to disambiguate variable vs function timedout(). Can we maybe name them differently? - Niklas Nielsen On Nov. 11, 2014, 8:52 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27499/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 8:52 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas > Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/clock.hpp > eb157cac996c48fedc69002b9d80adaba1ed85d1 > 3rdparty/libprocess/src/process.cpp > 85fb9958342f0bcdde322d9c55333126e6f86668 > > Diff: https://reviews.apache.org/r/27499/diff/ > > > Testing > ------- > > This enables seperating the Clock specific functionality from the > ProcessManager functionality so that the Clock implementation can ultimately > be completely isolated. > > > Thanks, > > Benjamin Hindman > >
