> On Nov. 11, 2014, 11:14 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/process.cpp, line 3314 > > <https://reviews.apache.org/r/27501/diff/1/?file=747110#file747110line3314> > > > > It's hard to pick up (from the call site) what the last bool does - how > > about having a update() and force_update()?
I think this functionality was merged on purpose. If the bool is not explicit maybe an enum would be more clear? `Clock::update(this, Clock::now(__process__), Clock::force);` - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27501/#review60866 ----------------------------------------------------------- On Nov. 11, 2014, 4:52 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27501/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 4:52 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas > Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/clock.hpp > eb157cac996c48fedc69002b9d80adaba1ed85d1 > 3rdparty/libprocess/src/process.cpp > 85fb9958342f0bcdde322d9c55333126e6f86668 > > Diff: https://reviews.apache.org/r/27501/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
