----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23913/#review61017 -----------------------------------------------------------
(Same here) Are you planning on getting this in? In that case, we need a shepherd to follow it through. - Niklas Nielsen On July 24, 2014, 6:17 p.m., Craig Hansen-Sturm wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23913/ > ----------------------------------------------------------- > > (Updated July 24, 2014, 6:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1626 > https://issues.apache.org/jira/browse/MESOS-1626 > > > Repository: mesos-git > > > Description > ------- > > This patch adds support for C++11 (and boost) <atomic> support to stout, > following the pattern in stout/lambda.hpp stout/memory.hpp > > However, to support pre-c+11 compilation, boost/atomic is used for the > fallback case, as there is no std::TR1 support. > > Note: with this fix, we still need to incorporate additional boost/atomic > headers (either via a patch, or a more general mechanism. Still waiting to > hear back from Timothy St. Clair about the proper staging). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/atomic.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/23913/diff/ > > > Testing > ------- > > make check > > compiled and ran all boost "lock free" sample-usage code specified at > http://www.boost.org/doc/libs/1_54_0/doc/html/atomic/usage_examples.html. > These samples compile and ran without modification (for both c++11 and boost). > > > Thanks, > > Craig Hansen-Sturm > >
