> On Nov. 12, 2014, 7:22 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/process.cpp, lines 1621-1624 > > <https://reviews.apache.org/r/27508/diff/1/?file=747126#file747126line1621> > > > > This was called before regardless if connect succeeded or failed - this > > changed here, do you know why?
io::poll does it's own management of the watcher, and enqueues it using run_in_event_loop(). So it does still happen for both paths. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27508/#review60671 ----------------------------------------------------------- On Nov. 11, 2014, 4:55 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27508/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 4:55 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas > Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 85fb9958342f0bcdde322d9c55333126e6f86668 > > Diff: https://reviews.apache.org/r/27508/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
