----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review61061 -----------------------------------------------------------
Ship it! It would be great to document in the Mesos style guide that we want to introduce this for use anywhere we use the "pimpl" pattern. 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 <https://reviews.apache.org/r/27351/#comment102513> s/check/Check/g - Benjamin Hindman On Nov. 12, 2014, 7:18 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27351/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 7:18 p.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Bugs: MESOS-2010 > https://issues.apache.org/jira/browse/MESOS-2010 > > > Repository: mesos-git > > > Description > ------- > > Introduce enable_shared_from_this to the configure check for Libprocess > > > Diffs > ----- > > 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 > > Diff: https://reviews.apache.org/r/27351/diff/ > > > Testing > ------- > > make check on gcc-4.4 > make check on gcc-4.9 > > > Thanks, > > Joris Van Remoortere > >
