----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27896/#review61135 -----------------------------------------------------------
Ship it! src/sched/sched.cpp <https://reviews.apache.org/r/27896/#comment102620> How about removing "the" to avoid the line wrap? Looks like the other messages omit "the". :) src/sched/sched.cpp <https://reviews.apache.org/r/27896/#comment102621> Could you wrap these all the same way? src/sched/sched.cpp <https://reviews.apache.org/r/27896/#comment102628> How about just saying that there can be another callback delivered on the scheduler if the SchedulerProcess was in the middle of processing an event. src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/27896/#comment102632> Just to be sure, does this test fails without the fix? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/27896/#comment102633> How about just StopThenAbort, or do you think that's not specific enough? - Ben Mahler On Nov. 12, 2014, 11:55 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27896/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 11:55 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Bill Farner. > > > Bugs: MESOS-2078 > https://issues.apache.org/jira/browse/MESOS-2078 > > > Repository: mesos-git > > > Description > ------- > > Updated the driver to drop inbound messages when either stop() or abort() is > called. > > > Diffs > ----- > > src/sched/sched.cpp d66218267ce1b7adc78edcbfaa67436d936284cf > src/tests/scheduler_tests.cpp 65021619b9a642b2fa4615c7d9a692331b5cc85d > > Diff: https://reviews.apache.org/r/27896/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
