> On Nov. 13, 2014, 12:38 a.m., Dominic Hamon wrote: > > m4/ax_cxx_compile_stdcxx_11.m4, line 111 > > <https://reviews.apache.org/r/27945/diff/1/?file=760765#file760765line111> > > > > do you also want to check that std::initializer_list can be used as a > > type in a constructor for a user-defined class? > > > > for completeness.
Adding > On Nov. 13, 2014, 12:38 a.m., Dominic Hamon wrote: > > m4/ax_cxx_compile_stdcxx_11.m4, line 112 > > <https://reviews.apache.org/r/27945/diff/1/?file=760765#file760765line112> > > > > we can avoid string header by using ints. > > > > it also shouldn't need to be static. I want to make sure the const char * -> std::string stuff works (especially since It's one of the things I use most commonly with initializer_list, and is relatively easy for a C++ compiler to get wrong. Dropping the static - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27945/#review61152 ----------------------------------------------------------- On Nov. 13, 2014, 12:35 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27945/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 12:35 a.m.) > > > Review request for mesos, Ben Mahler and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > Check both that initializer_list exists, and that a standard container > (vector) accepts it. > > > Diffs > ----- > > m4/ax_cxx_compile_stdcxx_11.m4 d166aa1adf56888ae8f6025469e35165e1f21d61 > > Diff: https://reviews.apache.org/r/27945/diff/ > > > Testing > ------- > > make distcheck with GCC on ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
