----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27651/#review61167 -----------------------------------------------------------
Patch looks great! Reviews applied: [27619, 27651] All tests passed. - Mesos ReviewBot On Nov. 12, 2014, 10:31 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27651/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 10:31 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-2041 > https://issues.apache.org/jira/browse/MESOS-2041 > > > Repository: mesos-git > > > Description > ------- > > CRAMMD5Authentication tests now cover all default and modularized > authenticator/authenticatee combinations. > Also adds a test for missing credential for the authenticatee. > > > Diffs > ----- > > src/tests/cram_md5_authentication_tests.cpp f91f1f9 > src/tests/module.hpp 7970c28 > src/tests/module.cpp 482ed22 > > Diff: https://reviews.apache.org/r/27651/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >