----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27605/#review61292 -----------------------------------------------------------
Ship it! Thanks Cody! I changed the commit message slightly on this one: "Added a unit test for path::join." 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp <https://reviews.apache.org/r/27605/#comment102839> Ah, I meant to remove these since they aren't testing anything specific to path::join (namely, we don't care here that implicit string construction is allowed). I'll take care of this for you. - Ben Mahler On Nov. 13, 2014, 12:39 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27605/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 12:39 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1733 and mesos-1877 > https://issues.apache.org/jira/browse/MESOS-1733 > https://issues.apache.org/jira/browse/mesos-1877 > > > Repository: mesos-git > > > Description > ------- > > Add a unit test to stout path to increase confidence when changing the code. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 7aac3fdb864e838cdd4e0d817ed4dff14923c69d > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > bc6920a24d920c809e36a2a3da1810e52d0db101 > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/27605/diff/ > > > Testing > ------- > > make distcheck on Ubuntu 14.04 > > NOTE: ReviewBot is going to be unhappy about this "crossing" stout and > libprocess... I'm not sure what the correct fix for reviewbot is in this > case, since the Makefile does really cross the project bounds... > > > Thanks, > > Cody Maloney > >