----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27958/#review61294 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment102842> why the leading _? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment102841> unique_ptr? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27958/#comment102851> i'm not a fan of the implicit conversion here. Can we make this explicit socket.get()? - Dominic Hamon On Nov. 12, 2014, 6:52 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27958/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 6:52 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1330 > https://issues.apache.org/jira/browse/MESOS-1330 > > > Repository: mesos-git > > > Description > ------- > > See Summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 66838814236fc064a2463399fb15f4a815879bf5 > 3rdparty/libprocess/src/process.cpp > a34b8702b01dec9c954552de0b923866d172c453 > > Diff: https://reviews.apache.org/r/27958/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
