----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27960/#review61401 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27960/#comment102969> Have you tried to do a scan and see where you can introduce constness? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27960/#comment102970> If this failed, do you still want to continue with the read? If not, you need to return here. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27960/#comment102966> Why passing this along if we ignore the argument in decode_read_failed? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27960/#comment102967> Why throw away the constness? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27960/#comment102968> Mind adding a comment on why you are allocating the space up-front? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/27960/#comment102964> Mind adding a comment on why you are grabbing a copy. - Niklas Nielsen On Nov. 12, 2014, 6:52 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27960/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 6:52 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1330 > https://issues.apache.org/jira/browse/MESOS-1330 > > > Repository: mesos-git > > > Description > ------- > > See Summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 66838814236fc064a2463399fb15f4a815879bf5 > 3rdparty/libprocess/src/process.cpp > a34b8702b01dec9c954552de0b923866d172c453 > > Diff: https://reviews.apache.org/r/27960/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
