> On Nov. 11, 2014, 10:49 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/clock.hpp, line 8 > > <https://reviews.apache.org/r/27498/diff/1/?file=747103#file747103line8> > > > > Where are you using Nothing()?
Oops, thanks! > On Nov. 11, 2014, 10:49 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 1139 > > <https://reviews.apache.org/r/27498/diff/1/?file=747104#file747104line1139> > > > > Do you have an example of how that could happen? I updated the comment to explain the situation better. > On Nov. 11, 2014, 10:49 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/process.cpp, line 3120 > > <https://reviews.apache.org/r/27498/diff/1/?file=747105#file747105line3120> > > > > s/in actuallity//? Thanks! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27498/#review60852 ----------------------------------------------------------- On Nov. 14, 2014, 11:15 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27498/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 11:15 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas > Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/clock.hpp > eb157cac996c48fedc69002b9d80adaba1ed85d1 > 3rdparty/libprocess/include/process/future.hpp > 3ac1812ae3786dac4779d265cdd87f4cbe00b9f7 > 3rdparty/libprocess/src/process.cpp > 5842705ae78ebe36c1c01bfcd468e9ebe55de3be > > Diff: https://reviews.apache.org/r/27498/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >