> On Nov. 14, 2014, 10:04 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 40 > > <https://reviews.apache.org/r/27962/diff/2/?file=764031#file764031line40> > > > > we have runtime type information. why do you need this?
We're using a virtual dispatch to get this enum in order to determine what kind of send function to use. Since we expect there to be multiple implementations of the class Socket::Impl, it doesn't really make sense to move the send functionality into the encoder. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27962/#review61519 ----------------------------------------------------------- On Nov. 14, 2014, 10:03 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27962/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 10:03 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1330 > https://issues.apache.org/jira/browse/MESOS-1330 > > > Repository: mesos-git > > > Description > ------- > > Introduce enumeration in Encoder to distinguish between data and file > encoders. > > > Diffs > ----- > > 3rdparty/libprocess/src/encoder.hpp > 9c5aa8134c101214d740bf231559ce5b5d51764c > > Diff: https://reviews.apache.org/r/27962/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
