----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28093/#review61662 -----------------------------------------------------------
I agree that we should add `empty()` so that we can use `empty()` rather than `size() == 0` and `!empty()` rather than `size() > 0`. But do you think we should get rid of `size()`? It seems like a reasonable thing to be able to do on a list of resources. - Michael Park On Nov. 15, 2014, 7:24 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28093/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 7:24 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > The semantics of "size()" is not clear. Replace it with empty(). > > > Diffs > ----- > > include/mesos/resources.hpp 0e37170 > src/master/hierarchical_allocator_process.hpp 31dfb2c > src/master/master.cpp 4b5d582 > src/tests/resources_tests.cpp 3e50889 > > Diff: https://reviews.apache.org/r/28093/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
