----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28089/#review61669 -----------------------------------------------------------
src/common/resources.cpp <https://reviews.apache.org/r/28089/#comment103428> I know you didn't touch this part, but could you make it so that `Resources Resources::operator + (const Resource& that) const` is implemented in terms of this instead of the other way around? Pretty much the exact same pattern as what you did for `Resource& operator += (Resource& left, const Resource& right)` and `Resource operator + (const Resource& left, const Resource& right)`. - Michael Park On Nov. 15, 2014, 6:56 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28089/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 6:56 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > Hide operators for Resource object. Split "matches" to handle future first > class infos. > > > Diffs > ----- > > include/mesos/resources.hpp 0e37170 > src/common/resources.cpp e9a0c85 > src/tests/resources_tests.cpp 3e50889 > > Diff: https://reviews.apache.org/r/28089/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
