----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28125/#review61768 -----------------------------------------------------------
Thanks Joris! Feel free to have someone just get this committed with the minor adjustments. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28125/#comment103649> IMO the added comments are unnecessary, not provided more insight over just reaing the code. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28125/#comment103647> What does "link" mean in this context? How about: "Failed to create socket, os::nonblock: " + ... Ditto below. - Ben Mahler On Nov. 17, 2014, 6:47 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28125/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 6:47 p.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff, > and Vinod Kone. > > > Bugs: MESOS-2116 > https://issues.apache.org/jira/browse/MESOS-2116 > > > Repository: mesos-git > > > Description > ------- > > Test whether SOCK_NONBLOCK and SOCK_CLOEXEC are defined to use single system > call to create socket. > Otherwise use os::nonblock and os::cloexec after creating the socket. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 20136ba4c65883b8bbcc8498e09f7ff7b50b68a4 > > Diff: https://reviews.apache.org/r/28125/diff/ > > > Testing > ------- > > make check on linux > make check on macos > > > Thanks, > > Joris Van Remoortere > >
