> On Nov. 17, 2014, 10:22 p.m., Ben Mahler wrote: > > Please also send some patches to document these changes in the CHANGELOG! > > All of these resources.hpp changes are technically breaking changes for > > users of the C++ API! > > > > In the longer term, maybe it makes sense to keep Resources a simple > > abstraction, allowing others to abstractions atop it for their needs. For > > us, that will mean making our example frameworks use an internal > > abstraction that provides allocation primitives. I agree that allocation > > primitives don't belong here.
Created https://issues.apache.org/jira/browse/MESOS-2123 to track. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28090/#review61823 ----------------------------------------------------------- On Nov. 15, 2014, 7:01 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28090/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 7:01 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > See summary. Frameworks should have their own allocation logics. We shouldn't > embed an allocation logic in mesos interface. > > > Diffs > ----- > > include/mesos/resources.hpp 0e37170 > src/common/resources.cpp e9a0c85 > src/tests/resources_tests.cpp 3e50889 > > Diff: https://reviews.apache.org/r/28090/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
