----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28195/#review62069 -----------------------------------------------------------
Ship it! Ship It! 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/28195/#comment104005> these should all be able to be labeled const. - Dominic Hamon On Nov. 18, 2014, 4:03 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28195/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 4:03 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Niklas Nielsen, > and Timothy Chen. > > > Bugs: MESOS-2126 > https://issues.apache.org/jira/browse/MESOS-2126 > > > Repository: mesos-git > > > Description > ------- > > Factor out callback invocation in Future to make the logic easier to read. It > also de-duplicates some code. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 2e4f9efe53e2e9966f23bd516e61fd9d83ed6b33 > > Diff: https://reviews.apache.org/r/28195/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
