> On Nov. 19, 2014, 8:48 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/http.cpp, line 49 > > <https://reviews.apache.org/r/28253/diff/1/?file=770209#file770209line49> > > > > if I understand correctly about querystrings, there isn't a possible > > case you can have a key with a empty value right? I know it's possible to > > have null keys and values. > > Cody Maloney wrote: > Keys with empty values do happen in some HTTP APIs I've used before. > Generally there isn't a well-defined scheme for query strings in an RFC > unfortunately. Without this logic we end up with 'key=&nextkey=foobar' which > I find misleading to read compared to 'key&nextkey=foobar'. > > You can think of valueless keys like optional command line flags which > take no parameters.
ok, but also i yhink keyless values are also represented the same way (value vs =value). if we want to be inclusive then you need to encode keyless calues withh just the value as well - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28253/#review62221 ----------------------------------------------------------- On Nov. 19, 2014, 8:30 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28253/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 8:30 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2132 > https://issues.apache.org/jira/browse/MESOS-2132 > > > Repository: mesos-git > > > Description > ------- > > Add query string joiner > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 9cf05acbb724ab9af8010d1788621d37a0e48e86 > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > 3rdparty/libprocess/src/tests/http_tests.cpp > a90e65f77904da0a45e1cc0cc9889ae69354a1a5 > > Diff: https://reviews.apache.org/r/28253/diff/ > > > Testing > ------- > > make distcheck ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
