> On Nov. 20, 2014, 12:16 a.m., Timothy Chen wrote: > > src/files/files.cpp, line 151 > > <https://reviews.apache.org/r/27606/diff/1/?file=750089#file750089line151> > > > > Why Future<bool>? This seems to return right away. > > And it doesn't look like a interface you want to extend too.
attach() and detach() are called through a dispatch(), this hooks up to that future (See the Files::detach() wrapper which dispatches through libprocess at the end of the file to call this function. The primary motivation here for adding a return is so that we can check that attach() and detach() are actually symmettric (Most callers don't care if they weren't able to detach something which doesn't exist). Prior to adding standardizePath in this patch there was a whole swath of cases where attach() and detach() would not end up matching eachother given the same path. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27606/#review62298 ----------------------------------------------------------- On Nov. 5, 2014, 2:53 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27606/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 2:53 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: mesos-1877 > https://issues.apache.org/jira/browse/mesos-1877 > > > Repository: mesos-git > > > Description > ------- > > Files attach, detach, and browse now all call a single function to > standardize the path. Before attach, browse did the normalization. Detach did > not. > > Switch to strings::tokenize() for splitting apart the path into tokens, as > that is more canonical across the codebase, used by libprocess for > proccessing paths. > > Update detach to return a bool of whether or not the detach does anything > which means that it can be tested. > > Add some additional testing to catch the inconsistencies in path handlign > between attach and detach previously, some of the oddness in current path > handling so that they can be explicitly seen when changes happen. > > > Diffs > ----- > > src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9 > src/files/files.cpp 12e8f75aa7bd77d2e81d5d3a7a4d09dd915854aa > src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451 > > Diff: https://reviews.apache.org/r/27606/diff/ > > > Testing > ------- > > make distcheck on ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
