-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28264/#review62462
-----------------------------------------------------------
Is there a string format that encodes disk resources with DiskInfo? E.g.
--resources="disk(ben):1024 disk:{persistence:{id...". Have you thought about
that?
src/common/resources.cpp
<https://reviews.apache.org/r/28264/#comment104504>
This confused me initially, how about saying "... same as setting an empty
DiskInfo, therefore we just call .disk() even if it's not set."
src/common/resources.cpp
<https://reviews.apache.org/r/28264/#comment104505>
(e.g. across slaves)
src/common/resources.cpp
<https://reviews.apache.org/r/28264/#comment104506>
Could you add a note about why subtractable needs to be called?
- Ben Mahler
On Nov. 20, 2014, 12:05 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28264/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 12:05 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to
> 'mcypark', and Vinod Kone.
>
>
> Bugs: MESOS-2135
> https://issues.apache.org/jira/browse/MESOS-2135
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 61d16a88bb1300c343c4f3141d5a068dbba933bd
> src/tests/resources_tests.cpp 73f50ba4f5c5db591180edd1fef1a3ecf6e03185
>
> Diff: https://reviews.apache.org/r/28264/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
