----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28387/#review62800 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp <https://reviews.apache.org/r/28387/#comment104922> this should be a class, and some of this stuff should be private. I'll let you figure out what :) 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp <https://reviews.apache.org/r/28387/#comment104923> explicit - avoid implicit conversions. same below. 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp <https://reviews.apache.org/r/28387/#comment104924> add this to the initializer section instead: explicit IPAddress(struct in_addr _ipv4_addr) : family(AF_INET), ipv4_addr(_ipv4_addr) {} 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp <https://reviews.apache.org/r/28387/#comment104925> bring the braces up a line. 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp <https://reviews.apache.org/r/28387/#comment104926> i don't think this is what you want. you're creating a stack IPAddress, then implicitly converting the in6_addr to an IPAddress, then using the IPAddress equality operator. return in6addr_loopback == ipv6_addr should work. and avoid all that creation/conversion :) 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp <https://reviews.apache.org/r/28387/#comment104928> CHECK family is AF_INET 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp <https://reviews.apache.org/r/28387/#comment104929> fix up your braces please 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp <https://reviews.apache.org/r/28387/#comment104930> some whitespace would be great :) - Dominic Hamon On Nov. 23, 2014, 9:49 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28387/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 9:49 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Create an IP address abstraction such that every callsite does not need to > check the family and get the right address. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 00a4edd0bcde3f92630fb173aeb4fff8e9139f77 > 3rdparty/libprocess/3rdparty/stout/include/stout/ipaddress.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/28387/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
