----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28386/#review62802 -----------------------------------------------------------
src/common/protobuf_utils.hpp <https://reviews.apache.org/r/28386/#comment104931> const MasterInfo& info src/common/protobuf_utils.cpp <https://reviews.apache.org/r/28386/#comment104932> oof, this seems clumsy. how will it extend to IPv6? do we need to define a protobuf IPAddress soon? src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/28386/#comment104933> hm. is there a better way to construct this? src/master/http.cpp <https://reviews.apache.org/r/28386/#comment104934> you're in namespace mesos::internal already, so you can drop that. src/master/master.cpp <https://reviews.apache.org/r/28386/#comment104935> isLoopback()? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/28386/#comment104936> maybe there should be a static net::IPAddress that is LOOPBACK. would that help? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/28386/#comment104937> Please add methods to IPAddress to return the sockaddr (or even the net::IP) so you can check the family and return the right one. - Dominic Hamon On Nov. 23, 2014, 9:48 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28386/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 9:48 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Create an IP address abstraction such that every callsite does not need to > check the family and get the right address. > > > Diffs > ----- > > src/common/protobuf_utils.hpp bc3ef2a5f4e80c511d19cff6a4fb822c8d247571 > src/common/protobuf_utils.cpp baf04a6434e6f19e7e06e98c2d7795f87087eb0b > src/linux/routing/filter/icmp.cpp 12b9eb75135602ee6d4caa92ad7275f266d742eb > src/linux/routing/filter/ip.cpp 74525a9e6be8c96cda0940011d7cd930876e0394 > src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8 > src/master/master.cpp 5957db6538c1c66a4cc42c14f3908c0c2cc35f39 > src/sched/sched.cpp 0b08512d1b33857be89246d197184b0cc98e0540 > src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e > src/slave/containerizer/isolators/network/port_mapping.cpp > 3755413b566726a11d584c5149b55c20ab9619da > src/slave/slave.cpp 373c8b44f5bc000da801b0925e1a9c346d9ffabf > src/tests/master_contender_detector_tests.cpp > d847a30d21b2a2980c6b7ceb62bbf61dc77487de > src/tests/master_tests.cpp 065fc3e055f16949f8462779cdd1f410fa1ea59a > src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df > > Diff: https://reviews.apache.org/r/28386/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
