----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28402/#review62884 -----------------------------------------------------------
Please also see my comments in rr28401. src/hook/hook.hpp <https://reviews.apache.org/r/28402/#comment105003> Same as in rr28401: I don't think we can use `std::tuple`. src/hook/manager.cpp <https://reviews.apache.org/r/28402/#comment105012> Suppose we have `n` hooks that re-implement only `launchExecutor()`. This code adds `n * t1` overhead, though it effectively does nothing. Can we avoid this somehow? - Alexander Rukletsov On Nov. 24, 2014, 7:50 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28402/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 7:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2060 > https://issues.apache.org/jira/browse/MESOS-2060 > > > Repository: mesos-git > > > Description > ------- > > Similar in spirit to the Master hooks. > > > Diffs > ----- > > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/slave/slave.cpp 373c8b44f5bc000da801b0925e1a9c346d9ffabf > > Diff: https://reviews.apache.org/r/28402/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
