> On Nov. 24, 2014, 5:21 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/process.cpp, line 1277 > > <https://reviews.apache.org/r/28384/diff/1/?file=774056#file774056line1277> > > > > how are you going to extend this to IPv6?
the family field from IPAddress(see Node) and the sa_family from addr will identify the type of the socket created. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28384/#review62797 ----------------------------------------------------------- On Nov. 24, 2014, 5:47 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28384/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 5:47 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1916 > https://issues.apache.org/jira/browse/MESOS-1916 > > > Repository: mesos-git > > > Description > ------- > > SockaddrStorage uses struct sockaddr_storage (a placeholder for sockaddr_in > and sockaddr_in6 structures) and is convenient for when you need a struct > sockaddr(eg: for bind, connect calls). > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e > 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713 > 3rdparty/libprocess/src/process.cpp > cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14 > 3rdparty/libprocess/src/tests/http_tests.cpp > a90e65f77904da0a45e1cc0cc9889ae69354a1a5 > 3rdparty/libprocess/src/tests/process_tests.cpp > dec62e88ec993433e1a0777593bb2657b43636dc > > Diff: https://reviews.apache.org/r/28384/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
