> On Dec. 3, 2014, 10:18 p.m., Jie Yu wrote: > > src/master/allocator.hpp, lines 83-86 > > <https://reviews.apache.org/r/28665/diff/1/?file=781875#file781875line83> > > > > Maybe mention that slaveInfo resources are from --resources from slave > > command line.
Thanks! Will do. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28665/#review63755 ----------------------------------------------------------- On Dec. 3, 2014, 7:53 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28665/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 7:53 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > This will be necessary once we introduce persistent resources on the slave, > at which point the "total" resources for the slave is not reflected in the > SlaveInfo. It also may change later, which means we'll need to also introduce > a mechanism for dynamically updating the "total" resources for a slave. > > I will address updating the total resources for a slave in a subsequent > change. > > > Diffs > ----- > > src/master/allocator.hpp 02d20d0cc802805bc702891306aa42894531b223 > src/master/hierarchical_allocator_process.hpp > fbaa23fad37fc6cbe870932cd4ace6622080001b > src/master/master.cpp c840d497d9486cde970b11ba79e12feb15ee9ccf > src/tests/allocator_tests.cpp 1fcbb4a4c7ada2b88443c635b76c294848ac13d8 > src/tests/mesos.hpp f132c6caff471ce1be069f31eadb1d7e5d0f7dfd > src/tests/slave_recovery_tests.cpp 2b6c76af704b3b02da27fe463b3e52086d2d106a > > Diff: https://reviews.apache.org/r/28665/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
